Discussion:
[Bug-wget] [PATCH v3] src/host.c (sufmatch): Fix dot-prefixed domain matching
l***@gmail.com
2018-10-25 20:39:52 UTC
Permalink
From: Luiz Angelo Daros de Luca <***@gmail.com>

Current sufmatch does not match when domain is dot-prefixed.
The example of no_proxy in man (.mit.edu) does use a dot-prefixed
domain.

Signed-off-by: Luiz Angelo Daros de Luca <***@gmail.com>
---
src/host.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/host.c b/src/host.c
index b42cd6e8..2bf848f3 100644
--- a/src/host.c
+++ b/src/host.c
@@ -1033,8 +1033,9 @@ sufmatch (const char **list, const char *what)
/* Domain or subdomain match
* k == -1: exact match
* k >= 0 && what[k] == '.': subdomain match
+ * k >= 0 && list[i][0] == '.': dot-prefixed subdomain match
*/
- if (j == -1 && (k == -1 || what[k] == '.'))
+ if (j == -1 && (k == -1 || what[k] == '.' || list[i][0] == '.'))
return true;
}
--
2.19.0
Tim Rühsen
2018-10-26 20:58:04 UTC
Permalink
Applied. Thanks for your contribution !

Regards, Tim
Post by l***@gmail.com
Current sufmatch does not match when domain is dot-prefixed.
The example of no_proxy in man (.mit.edu) does use a dot-prefixed
domain.
---
src/host.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/host.c b/src/host.c
index b42cd6e8..2bf848f3 100644
--- a/src/host.c
+++ b/src/host.c
@@ -1033,8 +1033,9 @@ sufmatch (const char **list, const char *what)
/* Domain or subdomain match
* k == -1: exact match
* k >= 0 && what[k] == '.': subdomain match
+ * k >= 0 && list[i][0] == '.': dot-prefixed subdomain match
*/
- if (j == -1 && (k == -1 || what[k] == '.'))
+ if (j == -1 && (k == -1 || what[k] == '.' || list[i][0] == '.'))
return true;
}
Loading...