[Bug-wget] Wget localtime bug in 1.19.5

[Sam Bingner]

I had wget crashing when I compiled for iOS and tracked down the problem to be the rpl_localtime using the macro for localtime so it resolved to:

struct tm *
rpl_localtime (time_t const *timep)
{
struct tm *tm = rpl_localtime (timep);

This is because it has "-I ../src" in the CFLAGS so that can find config.h and time.h is found there before the system time.h

That obviously caused pretty bad things. Attached is a diff that fixed it for me.

Sam

[Tim Rühsen]

Hi Sam,

thanks for the report.

The problem might be fixed in upstream gnulib already. May I send you a
tarball with everything up-to-date for testing ?

BTW, ***@bingner.com doesn't seem to be a valid account (invalid DNS MX
or A/AAAA resource record). Please let me know where to send the tarball.

Regards, Tim

Post by Sam Bingner
struct tm *
rpl_localtime (time_t const *timep)
{
struct tm *tm = rpl_localtime (timep);
This is because it has "-I ../src" in the CFLAGS so that can find config.h and time.h is found there before the system time.h
That obviously caused pretty bad things. Attached is a diff that fixed it for me.
Sam