[Bug-wget] [bug #54828] wget stalled download shows wrong speed per second

[J]

URL:
<https://savannah.gnu.org/bugs/?54828>

Summary: wget stalled download shows wrong speed per second
Project: GNU Wget
Submitted by: now3d
Submitted on: Fri 12 Oct 2018 11:17:23 AM UTC
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Privacy: Public
Assigned to: None
Originator Name:
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Release: 1.19.4
Operating System: None
Reproducibility: None
Fixed Release: None
Planned Release: None
Regression: None
Work Required: None
Patch Included: None

_______________________________________________________

Details:

wget, where download stalls, display is stuck on "1.32MB/s" you can see below.
It should probably say "0MB/s (stalled)" ?

it could probably also have a second counter, as it is ambiguous it is
stalled, which lasts several minutes until it retries.

Also I am surprised it says "(Success)" after a read error, can that be
removed or replaced with "(Partial)"

I've obscured the URL, but you can use your own test case to reproduce.



$ wget https://www.mydomain123.com/tmp/mydomain123.zip
--2018-10-12 10:49:39-- https://www.mydomain123.com/tmp/mydomain123.zip
Resolving www.mydomain123.com (www.mydomain123.com)... 12.34.56.78
Connecting to www.mydomain123.com (www.mydomain123.com)|12.34.56.78|:443...
connected.
HTTP request sent, awaiting response... 200 OK
Length: 4954873 (4.7M) [application/zip]
Saving to: ‘mydomain123.zip’

mydomain123 57%[==========> ] 2.72M 1.40MB/s in 1.9s

2018-10-12 11:04:41 (1.40 MB/s) - Read error at byte 2850816/4954873
(Success). Retrying.

--2018-10-12 11:04:42-- (try: 2)
https://www.mydomain123.com/tmp/mydomain123.zip
Connecting to www.mydomain123.com (www.mydomain123.com)|12.34.56.78|:443...
connected.
HTTP request sent, awaiting response... 206 Partial Content
Length: 4954873 (4.7M), 2104057 (2.0M) remaining [application/zip]
Saving to: ‘mydomain123.zip’

mydomain123 100%[+++++++++++========>] 4.72M 1.37MB/s in 1.5s

2018-10-12 11:04:44 (1.37 MB/s) - ‘mydomain123.zip’ saved
[4954873/4954873]

$




_______________________________________________________

Reply to this item at:

<https://savannah.gnu.org/bugs/?54828>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/

[Darshit Shah]

Update of bug #54828 (project wget):

Status: None => Invalid
Open/Closed: Open => Closed

_______________________________________________________

Follow-up Comment #1:

This is actually two different issues.

Anyways, firstly, the speed being stuck is a technical limitation of Wget
being a single threaded application. Wget uses only blocking network sockets
and while it is blocked on a read() call, there is nothing it can do to update
the UI. Similarly, mentioning that it is stalled is also not possible without
adding threading support. Something that we do not intend to do. These issues
don't exist in Wget2 which has been designed with multi-threading from the
very beginning.

Regarding the "(Success)" string, that is not controlled by Wget at all. It is
in fact the string reported by the kernel for the last error. In your case, it
seems to be that the last socket operation was a success, but the connection
was still terminated.

_______________________________________________________

Reply to this item at:

<https://savannah.gnu.org/bugs/?54828>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/